Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unhide part of single selection NcSelect value #1293

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Aug 14, 2024

When editing a row with a single selection, part of it is hidden. This unhides it.

Before:
Screenshot from 2024-08-14 15-21-20

After:
Screenshot from 2024-08-14 15-22-52

@enjeck enjeck self-assigned this Aug 14, 2024
@enjeck enjeck changed the title fix: unhide part of NcSelect value fix: unhide part of single selection NcSelect value Aug 14, 2024
@juliusknorr
Copy link
Member

The text does not look fully centered vertically and the select input looks a bit too large (considering that the element size has been reduced with nextcloud 30). Could you check that as well? Maybe we are overwriting styles somewhere here as at least the examples in https://nextcloud-vue-components.netlify.app/#/Components/NcSelect?id=ncselect-1 seem fine

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to request changes for my comment ;)

@enjeck enjeck linked an issue Aug 16, 2024 that may be closed by this pull request
@enjeck enjeck dismissed juliusknorr’s stale review August 21, 2024 19:34

The text does not look fully centered vertically and the select input looks a bit too large (considering that the element size has been reduced with nextcloud 30). Could you check that as well? Maybe we are overwriting styles somewhere here as at least the examples in https://nextcloud-vue-components.netlify.app/#/Components/NcSelect?id=ncselect-1 seem fine This is unrelated to these changes. The problem exists on all selects, not just this. Fixed at #1307

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@juliusknorr juliusknorr merged commit 5901e00 into main Aug 22, 2024
47 checks passed
@juliusknorr juliusknorr deleted the fix-select branch August 22, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Clipped selection options
2 participants